Review Request 126942: LockScreen: Don't show layout variant in keyboard layout button
David Rosca
nowrep at gmail.com
Mon Feb 1 11:14:37 UTC 2016
> On Feb. 1, 2016, 11:10 a.m., Kai Uwe Broulik wrote:
> > That would give me "de" and "de" for "de(nodeadkeys)" and "de(neo)"
Hm, that's true. So it won't be that easy and will need to modify `org.kde.keyboard` api.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126942/#review91839
-----------------------------------------------------------
On Feb. 1, 2016, 11:08 a.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126942/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 11:08 a.m.)
>
>
> Review request for Plasma and Kai Uwe Broulik.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Displaying layout variant makes the button too big.
>
>
> Diffs
> -----
>
> lookandfeel/contents/components/KeyboardLayoutButton.qml 0644f15
>
> Diff: https://git.reviewboard.kde.org/r/126942/diff/
>
>
> Testing
> -------
>
> "de(nodeadkeys)" is now just "de"
>
> Might be good idea to show full name in tooltip, but `tooltip: "str"` has no effect.
>
>
> Thanks,
>
> David Rosca
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160201/2a73a12a/attachment.html>
More information about the Plasma-devel
mailing list