Review Request 126930: sddm theme: Add keyboard layout button

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126930/#review91835
-----------------------------------------------------------



+1

If you're at it, could you perhaps have a look at the code that generates the label? :) In system tray and OSD it says "neo" and "de" for me whereas the lockscreen says "de(nodeadkeys)" which makes the button super huge and ugly.


lookandfeel/contents/loginmanager/Main.qml (line 128)
<https://git.reviewboard.kde.org/r/126930/#comment62694>

    This id is unused



lookandfeel/contents/loginmanager/Main.qml (line 129)
<https://git.reviewboard.kde.org/r/126930/#comment62692>

    I think it does that by default in QtQuick.Controls



lookandfeel/contents/loginmanager/dummydata/keyboard.qml (lines 9 - 12)
<https://git.reviewboard.kde.org/r/126930/#comment62693>

    You can do that in the property directly:
    
    property var layouts: [
        { shortName: "us", longName: "English" }
        ...
    ]


- Kai Uwe Broulik


On Jan. 30, 2016, 10:59 nachm., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126930/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2016, 10:59 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Show keyboard layout button in sddm theme, same as in lock screen.
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/loginmanager/Main.qml 1bbefec 
>   lookandfeel/contents/loginmanager/dummydata/keyboard.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126930/diff/
> 
> 
> Testing
> -------
> 
> Looks & works exactly the same as in lock screen.
> 
> Btw, there is a comment saying that password input must be first child to get focus (automatically when login screen is shown?), but it is not true. It works fine (in all cases = qmlscene, sddm-greeter --test-mode and in actual sddm session) even with password input being second child. So, remove the comment?
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160201/5fb458ae/attachment.html>