Review Request 126937: [KWindowSystemProxy] Add setter for showingDesktop

Martin Gräßlin mgraesslin at kde.org
Mon Feb 1 07:34:01 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126937/#review91833
-----------------------------------------------------------


Ship it!




> but the greeter window stayed there no matter what.

because the greeter window is an override redirect. Which means it's not a window the window manager manages and thus does not restack on show desktop.

- Martin Gräßlin


On Jan. 31, 2016, 3:58 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126937/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2016, 3:58 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> I don't know why this was omitted.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h 3e47f00 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp a70ce90 
> 
> Diff: https://git.reviewboard.kde.org/r/126937/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> I added it to the lockscreen qml in hopes of finding a privacy vulnerability but the greeter window stayed there no matter what. :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160201/85cdc197/attachment-0001.html>


More information about the Plasma-devel mailing list