[Differential] [Request, 60 lines] D3892: [Icon Item] Support non-square icons

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Sat Dec 31 17:08:16 UTC 2016


broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R242 Plasma Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  BUG: 355592

TEST PLAN
  Tests still pass, added a test for paintedWidth/paintedHeight
  F1663819: Screenshot_20161231_173902.png <https://phabricator.kde.org/F1663819>
  Now getting non-square thumbs in FolderView (will make a patch for FolderView to let IconItem span the full delegate width to make better use of available space for wide thumbs)
  Everything else looks as normal, icons still rounded to icon sizes and square usually, verified that paintedWidth/paintedHeight is always updated and correct

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3892

AFFECTED FILES
  autotests/iconitemtest.cpp
  autotests/iconitemtest.h
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161231/1e7b6959/attachment.html>


More information about the Plasma-devel mailing list