[Differential] [Commented On] D3885: Minor fix for plasma folder view filename editor

[subdiff (Roman Gilg)]

subdiff added a comment.


  Good find but why does it need to compare `_height` with `contentHeight` in the beginning at all? Normally what should imo happen is simply:
  
  - Compare `realHeight` with max possible height `maxHeight`
  - If larger, set `_height = realHeight`, else `_height = maxHeight`
  
  So just: `_height = Math.min(realHeight, maxHeight)`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3885

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: chinmoyr, #plasma
Cc: subdiff, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161231/0100b85b/attachment.html>