Review Request 129732: Fix regression in which the save dialog appears as an Open dialog

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129732/#review101680
-----------------------------------------------------------



Thanks for the fix! I did notice something strange with save dialogs lately ;-)


autotests/kfiledialog_unittest.cpp (line 101)
<https://git.reviewboard.kde.org/r/129732/#comment68099>

    Not needed, auto-remove is on by default.



autotests/kfiledialog_unittest.cpp (line 106)
<https://git.reviewboard.kde.org/r/129732/#comment68100>

    A better approach would be
       QTRY_VERIFY(findFileWidget());
    
    This will repeatedly call findFileWidget() until it works or until 5 seconds have passed.
    Then you don't need timers nor separate methods nor a new member variable. The rest of the test can just follow that line.


- David Faure


On Dec. 31, 2016, 1:20 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129732/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2016, 1:20 a.m.)
> 
> 
> Review request for Plasma, David Faure and Friedrich W. H. Kossebau.
> 
> 
> Repository: plasma-integration
> 
> 
> Description
> -------
> 
> 7bbbd93cd3fc0abdffd3fa7f144cb50a33fafad9 makes the save dialog appear as Open dialog.
> 
> Simplify the code in that commit so it does not regress anymore.
> 
> Comes with a unit test (argably a bit meh since it could loop forever if the dialog does not show, but i guess it is good if that happens too :D)
> 
> 
> Diffs
> -----
> 
>   autotests/kfiledialog_unittest.cpp 47a5543 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 990b983 
> 
> Diff: https://git.reviewboard.kde.org/r/129732/diff/
> 
> 
> Testing
> -------
> 
> New test fails without the patch, works with it. Kate Save As dialog no longer shows as Open dialog.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161231/342a8138/attachment.html>