[Differential] [Accepted] D3863: Introduce an InputEventSpy for processing input events

[sebas (Sebastian Kügler)]

sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.


  Some minor stuff, looks good overall.

INLINE COMMENTS

> input.cpp:1394
> +{
> +    m_spies.removeOne(spy);
> +}

Wouldn't removeAll() be a bit safer here, or is there a good reason to have spies enqueued twice? (In that case, duplicates should probably be checked before insertion.

In any case, it should be consistent with the filters' behaviour, so just something to think about.

> input.h:192
> +     * The intended usage is to std::bind the method to invoke on the spies with all arguments
> +     * bind.
> +     **/

Code example would be nice here. Not critical, since it's not public API anyway, but would help *me* personally to understand a bit better how to use it.

> input_event_spy.h:50
> +    /**
> +     * Event filter for pointer events which can be described by a MouseEvent.
> +     *

spy, not filter (we should use that language consistently: filters may remove events, spies just snoop)

> input_event_spy.h:56
> +    /**
> +     * Event filter for pointer axis events.
> +     *

spy

> input_event_spy.h:62
> +    /**
> +     * Event filter for keyboard events.
> +     *

spy

REPOSITORY
  R108 KWin

BRANCH
  input-event-spy

REVISION DETAIL
  https://phabricator.kde.org/D3863

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, sebas
Cc: sebas, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161229/16137157/attachment-0001.html>