[Differential] [Request, 4 lines] D3847: SWT/Eclipse toolbar fix

jsalatas (John Salatas) noreply at phabricator.kde.org
Thu Dec 29 07:30:30 UTC 2016


jsalatas created this revision.
jsalatas added a reviewer: Breeze.
jsalatas set the repository for this revision to R98 Breeze for Gtk.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  In eclipse running with  SWT gtk2 the buttons in the toolbar don't behave as they should:
  
  1. There is no highlighting when hovering
  2. For toggle buttons there is no active/inactive indication.

TEST PLAN
  Tested in KDE Neon User as of December, 28th
  
  Before
  F1588340: before.png <https://phabricator.kde.org/F1588340>
  
  After 
  F1588341: after.png <https://phabricator.kde.org/F1588341>
  
  Besides these two issues the patch seems to (unintentionally) improve some real-estates (see for example secondary toolbar buttons in Package Explorer and Outline views).

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D3847

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/styles
  Breeze-gtk/gtk-2.0/widgets/styles

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #breeze
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161229/4b8b1aae/attachment.html>


More information about the Plasma-devel mailing list