[Differential] [Request, 85 lines] D3838: [Calendar] Optimize day delegate
broulik (Kai Uwe Broulik)
noreply at phabricator.kde.org
Wed Dec 28 14:48:23 UTC 2016
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Frameworks.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
- Use a single global MouseArea and turn delegate into an Item
- Use a single Rectangle for both "today" and "highlighted" state
- Add font.pointSize: -1 workaround in the other labels to avoid runtime warnings
TEST PLAN
- Hovering and selecting items still works, updates agenda as needed, also "has appointment" overlay still works
- Switching between months updates the highlight - you can see a brief transition from gray to blue and then invisible when you move between the current month and others as the single Rectangle will transition from gray to blue in response to becoming "not today" and opacity 1 to 0 in response to being no longer selected, not too terrible, though.
- Pinch to zoom still works
- didn't notice stray highlight when closing popup with mouse still hovering
Unfortunately did not result in a noticeable speedup of first invocation
REPOSITORY
R242 Plasma Frameworks
REVISION DETAIL
https://phabricator.kde.org/D3838
AFFECTED FILES
src/declarativeimports/calendar/qml/DayDelegate.qml
src/declarativeimports/calendar/qml/DaysCalendar.qml
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161228/448db769/attachment.html>
More information about the Plasma-devel
mailing list