[Differential] [Request, 65 lines] D3837: [Calendar] Optimize Backend

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Wed Dec 28 14:43:50 UTC 2016


broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Frameworks.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  - Use QQmlParserStatus to avoid premature initialization
  - Requires the days model to signal a model reset as by the time the Repeater in QML read the model for the first time it's empty (avoids boolean trap in "update" method signature by using an enum ;)
  - Don't signal weeks"Model" changed if it didn't - emitting a changing variant list / json array will cause QML to destroy and re-create all delegates

TEST PLAN
  Calendar still seems to work. Week number column still works.
  
  Unfortunately did not result in a noticeable speedup of first invocation

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3837

AFFECTED FILES
  src/declarativeimports/calendar/calendar.cpp
  src/declarativeimports/calendar/calendar.h
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/daysmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161228/583f1e84/attachment-0001.html>


More information about the Plasma-devel mailing list