Review Request 129697: Figure out software center integration on the menus
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Dec 28 11:21:02 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129697/
-----------------------------------------------------------
(Updated Dec. 28, 2016, 11:21 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit 27d71ef5f394f6a53aff3e022ae0145e09e89765 by Aleix Pol to branch master.
Repository: plasma-desktop
Description
-------
So far we had a (commented out) entry that was called `Remove <application package>` that would open the configured application.
* Instead of looking up the service files in PackageKit, it does so on AppStream, allowing for a faster and sync approach.
* Renames the action to `Open <application name>`.
* Uses `appstream://` URI scheme, allowing for the system to decide which application handles it rather than an awkward configuration entry.
* Drops PackageKit-Qt opcional dependency, adds a required AppstreamQt dependency instead.
This also means that applications coming from other sources than the packaging system (i.e. Snappy, Flatpak or AppImage) would also be supported, as long as it's supported by the package manager.
Diffs
-----
CMakeLists.txt 90aaa03e
applets/kicker/CMakeLists.txt 2e112e42
applets/kicker/package/contents/config/main.xml bfd0d2db
applets/kicker/plugin/appentry.cpp 5efdb0d0
applets/kicker/plugin/findpackagenamejob.h 9905182c
applets/kicker/plugin/findpackagenamejob.cpp aa3fd549
applets/kickoff/package/contents/config/main.xml d7c51624
config-workspace.h.cmake d0b48b94
Diff: https://git.reviewboard.kde.org/r/129697/diff/
Testing
-------
Manual testing, opened few applications, all worked fine.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161228/c0d4fe6a/attachment.html>
More information about the Plasma-devel
mailing list