Review Request 129704: Delegate plasmapkg2 completely into kpackagetool5

Aleix Pol Gonzalez aleixpol at kde.org
Tue Dec 27 18:12:40 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129704/
-----------------------------------------------------------

(Updated Dec. 27, 2016, 6:12 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
-------

Submitted with commit dc4474125ca85003ade1550517f602cde1b70ab8 by Aleix Pol to branch master.


Repository: plasma-framework


Description
-------

They're supposed to do the same, completely different codebases. Also some things had to be ported.

I'd recommend everything to be ported to use kpackagetool (knsrc files!) but still it's better to at least make sure we stick to one set of features.


Diffs
-----

  src/plasmapkg/CMakeLists.txt 7d3df5d22 
  src/plasmapkg/main.cpp dfbd2f4c3 
  src/plasmapkg/plasmapkg.h 3383980db 
  src/plasmapkg/plasmapkg.cpp 3724ae85e 

Diff: https://git.reviewboard.kde.org/r/129704/diff/


Testing
-------

`plasmapkg2 --help` returns `kpackagetool5`'s.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161227/9ade46fa/attachment-0001.html>


More information about the Plasma-devel mailing list