Review Request 129691: digital-clock: Update iso-3166 codes in timezones

Sebastian Kügler sebas at kde.org
Tue Dec 27 15:54:23 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129691/#review101595
-----------------------------------------------------------



In principle good, but Cabo Verde should not be changed. Can you change it back and resubmit, so we can get it in quickly?


applets/digital-clock/plugin/timezonesi18n.cpp (line 682)
<https://git.reviewboard.kde.org/r/129691/#comment68010>

    This should stay Cape Verde, the English name is used here, not the Portuguese (?) one.


- Sebastian Kügler


On Dec. 20, 2016, 9:57 p.m., Jiri Bohac wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129691/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2016, 9:57 p.m.)
> 
> 
> Review request for Plasma and Albert Astals Cid.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Update the list of country names to the current names in iso-codes
> (as output by isoquery -c).
> 
> The motivation is updating the name of Czechia as a followup to
> https://git.reviewboard.kde.org/r/129644/
> As suggested by Albert Astals Cid, fixing the name in i10n is not enough: 
> country names are hardcoded in many places and they need to be fixed separately.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/plugin/timezonesi18n.cpp 10650f8 
> 
> Diff: https://git.reviewboard.kde.org/r/129691/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jiri Bohac
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161227/795c4ef5/attachment-0001.html>


More information about the Plasma-devel mailing list