Review Request 129697: Figure out software center integration on the menus

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129697/#review101564
-----------------------------------------------------------



very neat :-) I especially like the red ration in the review request.


applets/kicker/plugin/appentry.cpp (line 155)
<https://git.reviewboard.kde.org/r/129697/#comment67992>

    please use an i18nc. I don't really get what Manage is supposed to do, so that needs help for translators ;-)


- Martin Gräßlin


On Dec. 23, 2016, 4:56 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129697/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2016, 4:56 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> So far we had a (commented out) entry that was called `Remove <application package>` that would open the configured application.
> 
> * Instead of looking up the service files in PackageKit, it does so on AppStream, allowing for a faster and sync approach.
> * Renames the action to `Open <application name>`.
> * Uses `appstream://` URI scheme, allowing for the system to decide which application handles it rather than an awkward configuration entry.
> * Drops PackageKit-Qt opcional dependency, adds a required AppstreamQt dependency instead.
> 
> This also means that applications coming from other sources than the packaging system (i.e. Snappy, Flatpak or AppImage) would also be supported, as long as it's supported by the package manager.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 90aaa03e 
>   applets/kicker/CMakeLists.txt 2e112e42 
>   applets/kicker/package/contents/config/main.xml bfd0d2db 
>   applets/kicker/plugin/appentry.cpp 5efdb0d0 
>   applets/kicker/plugin/findpackagenamejob.h 9905182c 
>   applets/kicker/plugin/findpackagenamejob.cpp aa3fd549 
>   applets/kickoff/package/contents/config/main.xml d7c51624 
>   config-workspace.h.cmake d0b48b94 
> 
> Diff: https://git.reviewboard.kde.org/r/129697/diff/
> 
> 
> Testing
> -------
> 
> Manual testing, opened few applications, all worked fine.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161224/1e94b13e/attachment.html>