Review Request 128552: Italicise the name of symlink in folder view plasmoid
Marco Martin
notmart at gmail.com
Thu Dec 22 10:44:32 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128552/#review101548
-----------------------------------------------------------
Ship it!
Ship It!
- Marco Martin
On Sept. 11, 2016, 11:01 p.m., Chinmoy Ranjan Pradhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128552/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2016, 11:01 p.m.)
>
>
> Review request for Plasma, KDE Usability and Eike Hein.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Same as summary.
>
>
> Diffs
> -----
>
> containments/desktop/package/contents/ui/FolderItemDelegate.qml b313d0f
> containments/desktop/plugins/folder/foldermodel.h 0e31b1e
> containments/desktop/plugins/folder/foldermodel.cpp 6abfb6b
>
> Diff: https://git.reviewboard.kde.org/r/128552/diff/
>
>
> Testing
> -------
>
> build
>
>
> File Attachments
> ----------------
>
> symlinks and other files/folders look similar
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/29/7428b23d-03f9-4aed-8ca0-536d44e45e8c__beforepatch.png
> after patch , everything looks fine
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/29/040b2e3b-9ea0-4347-9e6c-ca3bdb73b36a__link.png
> before patch
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/10/860d5b48-b88f-4994-bc70-ae8b6e4c91f7__beforepatch.png
> after patch
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/10/75649c76-e67e-41fb-8a37-3a73d2cae9b7__afterpatch.png
>
>
> Thanks,
>
> Chinmoy Ranjan Pradhan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161222/cb4af1a3/attachment-0001.html>
More information about the Plasma-devel
mailing list