Review Request 129679: Give names to knsrc files

Christoph Feck cfeck at kde.org
Tue Dec 20 19:10:29 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129679/#review101520
-----------------------------------------------------------


Ship it!





wallpapers/image/wallpaper.knsrc (line 2)
<https://git.reviewboard.kde.org/r/129679/#comment67962>

    If KNS wallpapers are downloaded to ~/.local/share/wallpapers, then everything is fine.
    
    If they are downloaded to some other (Plasma specific) location, then maybe rename to 'Plasma Wallpapers'.


- Christoph Feck


On Dec. 20, 2016, 6:51 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129679/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2016, 6:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> As discussed in 129654
> 
> 
> Diffs
> -----
> 
>   components/shellprivate/widgetexplorer/plasmoids.knsrc 19293b58 
>   wallpapers/image/wallpaper.knsrc bf646e6e 
> 
> Diff: https://git.reviewboard.kde.org/r/129679/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161220/1d359226/attachment.html>


More information about the Plasma-devel mailing list