[Differential] [Request, 3 lines] D3739: Correctly initialise and compare pa_cvolume structs

davidedmundson (David Edmundson) noreply at phabricator.kde.org
Mon Dec 19 18:22:26 UTC 2016


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Previously m_volume was uninitialised, resulting in a comparison on
  garbage data when first run.
  By using the proper pulse audio methods we can make sure to initialise
  the variable and use a faster compare than memcmp.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3739

AFFECTED FILES
  src/volumeobject.cpp
  src/volumeobject.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161219/56d720cf/attachment-0001.html>


More information about the Plasma-devel mailing list