[Differential] [Request, 1 line] D3736: Initialise m_volume in VolumeObject
davidedmundson (David Edmundson)
noreply at phabricator.kde.org
Mon Dec 19 17:27:44 UTC 2016
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We do a memcmp on m_volume to the new volume object
On the first run this is uninitialised resulting in comparing garbage
data, and a valgrind warning.
A similar fix was added by me for the cases in StreamRestore, but I had
missed this instance.
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3736
AFFECTED FILES
src/volumeobject.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161219/ac83cdfd/attachment.html>
More information about the Plasma-devel
mailing list