[Differential] [Commented On] D3707: add simple test rig for service runner

[sitter (Harald Sitter)]

sitter added inline comments.

INLINE COMMENTS

> dfaure wrote in servicerunnertest.cpp:5
> Is LGPL-v2-only on purpose here?

Not particularly. It's the same as the existing source file though, to have the same license restrictions apply to both. Is it worth changing it to gpgl2+kdev considering that?

> dfaure wrote in servicerunnertest.cpp:38
> Why futile? What is futile is the fear of breaking the user's cache ;)
> 
> You don't need any of this.
> 
> Since my big ksycoca refactoring a year ago, ksycoca's filename includes a SHA1 of the data dirs (see KSycoca::absoluteFilePath(), see also the filenames in your ~/.cache).
> So QStandardPaths::setTestModeEnabled(true); is already enough, given that it changes the local data home dir, so it changes the sha1.
> 
> See also e.g. kservice/autotests/kservicetest.cpp which doesn't change any env vars.
> 
> As a benefit it's also more portable to non-xdg platforms.

Awesome. Thanks!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3707

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, broulik, dfaure
Cc: dfaure, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161219/d17f133f/attachment-0001.html>