Review Request 129669: WindowThumbnail] Update thumbnail content

Marco Martin notmart at gmail.com
Mon Dec 19 09:55:31 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129669/#review101505
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On Dec. 18, 2016, 12:49 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129669/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2016, 12:49 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Bug is introdused in https://git.reviewboard.kde.org/r/128763/
> The problem is that releaseResources not call update since discardPixmap does. In fact update is needed after startRedirection
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/windowthumbnail.cpp a67453883 
> 
> Diff: https://git.reviewboard.kde.org/r/129669/diff/
> 
> 
> Testing
> -------
> 
> Steps to reproduce:
> 1. Enable window thumbnail in taskmanager
> 2. Hover task, wait for thumbnail
> 3. Minimize task
> 4. Move cursor out of panel
> 5. Move cursor over same task, wait for thumbnail
> 6. UpdatePaintNode does not called -> thumbnail is render black
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161219/846354d6/attachment.html>


More information about the Plasma-devel mailing list