Review Request 128038: [libtaskmanager] Stop highlighted window effect in group item

[Anthony Fieroni]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128038/
-----------------------------------------------------------

(Updated Dec. 16, 2016, 4:38 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Eike Hein.


Changes
-------

Submitted with commit aeec4ae8869b487fe516a920b49a1fde4ea48c06 by Anthony Fieroni to branch Plasma/5.8.


Repository: plasma-desktop


Description
-------

1. Enable highlighted window, tooltips and grouping
2. Open group item tasl by clicking left mouse button
3. Move mouse cursor over item in group

Before:
1. Items are samll and tough readable
2. Items aren't visible cause a highligthWindow effect
3. Clicking on tooltip close button case highlightWindow effect to not stop

After:
1. Items are proof readable
2. Items are visible
3. HighlightWdindow effect is stopped


Diffs
-----

  applets/taskmanager/package/contents/ui/GroupDialog.qml 829fcf0 
  applets/taskmanager/package/contents/ui/Task.qml 0a59d53 
  applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml e3551df 
  applets/taskmanager/package/contents/ui/main.qml e53b194 
  applets/taskmanager/plugin/backend.h a3788b0 
  applets/taskmanager/plugin/backend.cpp 4ef5b88 

Diff: https://git.reviewboard.kde.org/r/128038/diff/


Testing
-------

Screenshot with expected behavior by clicking left button on group item.


File Attachments
----------------

Vertical panel
  https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/35dd438c-fae2-4daa-ba30-09f70ea3b920__Screenshot_20161203_210914.png
Horizontal panel
  https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/fe7c9cab-bb2a-4d17-85de-1934c81a33dc__Screenshot_20161203_211120.png


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161216/760a3ed1/attachment.html>