[Differential] [Commented On] D3686: [platforms/hwcomposer] Support for hwcomposer 1.4 and 1.5 version

graesslin (Martin Gräßlin) noreply at phabricator.kde.org
Thu Dec 15 16:56:10 UTC 2016


graesslin added inline comments.

INLINE COMMENTS

> hwcomposer_backend.cpp:321
> +
> +#if defined(HWC_DEVICE_API_VERSION_1_4) || defined(HWC_DEVICE_API_VERSION_1_5)
> +    if (m_hwcVersion > HWC_DEVICE_API_VERSION_1_3)

hmm that doesn' t look really forward compatible. Can we have something like

  #if VERSION > 1_4

?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D3686

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, graesslin
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161215/9776fff5/attachment.html>


More information about the Plasma-devel mailing list