Review Request 129603: TextFieldStyle: Fix implicitHeight value so the text cursor is centered

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129603/#review101436
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On Dec. 2, 2016, 9:05 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129603/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2016, 9:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This makes the TextField slightly bigger, but cursor is now correctly centered.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmastyle/TextFieldStyle.qml 6174220 
> 
> Diff: https://git.reviewboard.kde.org/r/129603/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/12/02/9aa4f7fd-96b3-42a8-8938-cc1ab2d6ee66__before.png
> after.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/12/02/dadf758a-9298-4ed8-872e-947c308bcedb__after.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161214/d7be674c/attachment.html>