[Differential] [Commented On] D3649: Make kirigami.qrc ressource path relative to CMAKE_CURRENT_SOURCE_DIR

[franckarrecot (Franck Arrecot)]

franckarrecot added inline comments.

INLINE COMMENTS

> apol wrote in CMakeLists.txt:16
> Sounds like `${kirigami_SOURCE_DIR}/kirigami.qrc` would be best. I don't really understand the `..` you added though.

Well my main problem is when embedding kirigami as submodule in my cmake project, CMAKE_SOURCE_DIR is pointing to my top level source dir, not kirigami' one, so would be better to use a variable that can work on a standalone build of kirigamo or an "embedded" one.

So I thought that CMAKE_CURRENT_SOURCE_DIR was ok for this, and since it's refering to a file qrc which is one level upper than the current source dir I used CMAKE_CURRENT_SOURCE_DIR/..  to refer to it.

Is there a better way to refer to this file with a cmake variable which would not be impacted by the project kirigami is embedded into ?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D3649

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: franckarrecot, mart
Cc: apol, plasma-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161212/d24a9979/attachment.html>