[Differential] [Commented On] D3655: Kicker backend changes for Simple Menu.

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  some minor minor nitpicks, +1 from me though

INLINE COMMENTS

> rootmodel.cpp:281
>  
> -        foreach (const AbstractEntry *groupEntry, m_entryList) {
> -            AbstractModel *model = groupEntry->childModel();
> +                    for (int i = 0; i < subModel->count(); ++i) {
> +                        AppEntry *appEntry = static_cast<AppEntry*>(subModel->index(i, 0).internalPointer());

i is already occupied by the outer loop?

> rootmodel.cpp:293
> +
> +            apps = appsHash.values();
> +

Too bad there's no Qt container which keeps its custom order :)

> rootmodel.cpp:308
> +            int at = 0;
> +            QList<AbstractEntry *> page;
> +

reserve?

> rootmodel.cpp:323
>  
> -        QList<AbstractEntry *> groups;
> -        QHashIterator<QString, QList<AbstractEntry *>> i(m_categoryHash);
> +            if (page.count()) {
> +                AppsModel *model = new AppsModel(page, false, this);

!isEmpty

> rootmodel.h:90
>  
> +        void classBegin();
> +        void componentComplete();

override

> wheelinterceptor.cpp:52
> +
> +    emit wheelMoved(event->angleDelta());
>  }

Is this for another patch?

Also, you lose pixel-precise scrolling here

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3655

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161212/2f9baa5d/attachment-0001.html>