[Differential] [Commented On] D3630: [Digital Clock] Bug fixes and ui code optimization

[subdiff (Roman Gilg)]

subdiff added inline comments.

INLINE COMMENTS

> DigitalClock.qml:211
>  
> -                height: Math.max(sizehelper.lineCount > 1 ?  2 * Math.round(timeLabel.height / 6) : 2 * Math.round(timeLabel.height / 3), theme.smallestFont.pixelSize)
> +                height: Math.min(Math.max(sizehelper.lineCount > 1 ?  2 * Math.round(timeLabel.height / 6) : 2 * Math.round(timeLabel.height / 3), theme.smallestFont.pointSize), Math.round(timeLabel.height))
>                  width: main.width

@mart : Should this also stay in pixelSize? I assume in general always when comparing heights and font sizes, right?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3630

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161209/0d5fd192/attachment-0001.html>