[Differential] [Changed Subscribers] D3620: Add Plasmoid that shows multiple other plasmoids in a tabbed interface

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> groupingplasmoid.kdev4:1
> +[Buildset]
> +BuildItems=@Variant(\x00\x00\x00\t\x00\x00\x00\x00\x01\x00\x00\x00\x0b\x00\x00\x00\x00\x01\x00\x00\x00 \x00g\x00r\x00o\x00u\x00p\x00i\x00n\x00g\x00p\x00l\x00a\x00s\x00m\x00o\x00i\x00d)

this foder shouldn't be added

> groupedappletscontainer.cpp:132
> +            } else {
> +                m_innerContainment->setFormFactor(Plasma::Types::Horizontal);
> +            }

when this containment is in a desktop, shouldn't be better for it to be planer instead to let more applets to be expanded?

> main.qml:28
> +
> +    Layout.minimumWidth: internalSystray ? internalSystray.Layout.minimumWidth : 0
> +    Layout.minimumHeight: internalSystray ? internalSystray.Layout.minimumHeight : 0

rename *systray?

> groupingplasmoid.kdev4:1
> +[Project]
> +CreatedFrom=CMakeLists.txt

remove this file?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3620

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161208/5a659304/attachment-0001.html>