[Differential] [Commented On] D3578: [RFC] Implement drag from free space also for QtQuickControls

[hpereiradacosta (Hugo Pereira Da Costa)]

hpereiradacosta added a comment.


  Thanks for the updated patch !
  I tested it compiles on kde4
  Made a few suggestions above, then it can go.

INLINE COMMENTS

> breezewindowmanager.cpp:467
> +
> +            return true;
> +        }

should be "return false" 
Comments few lines below says we never eat events.

> breezewindowmanager.h:176
> +#if QT_VERSION >= 0x050000
> +#define WINDOW QWindow
> +#else

I'd rather use typedef, or even better

"using Window = QWindow;"
and "using Window = QWidget;"

instead of preprocessors

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3578

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, hpereiradacosta
Cc: mart, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161206/ea5e6868/attachment-0001.html>