[Differential] [Request, 763 lines] D3598: rework kscreen's OSD logic
sebas (Sebastian Kügler)
noreply at phabricator.kde.org
Mon Dec 5 17:15:42 UTC 2016
sebas created this revision.
sebas added a reviewer: Plasma.
sebas added a subscriber: davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This changeset moves the various OSDs used in kscreen (output identifier, display button feedback) into the kded module.
The functional change in here is that instead of calling into plasmashell, now kscreen renders its own OSD. Plasmashell falls short since it doesn't offer the controls which kscreen needs, namely deciding what ends up on which output. The display button feedback is done entirely in the kded module, the output identification bits will be called over dbus by the new kscreen module. (I don't want to change the old one too much at this point.)
The ui code also now works better on high dpi displays.
I've tested this code on Wayland and X11, and it works on both. The previous OSD code doesn't.
Delaying the display button switch now also allows us to indicate what actually happened after pressing the button, so the user gets much better feedback (after the changes have been applied.)
TEST PLAN
- tested on X11 and wayland, multi and single screen
- changeset contains a test app
REPOSITORY
R104 KScreen
BRANCH
sebas/osd
REVISION DETAIL
https://phabricator.kde.org/D3598
AFFECTED FILES
CMakeLists.txt
kded/CMakeLists.txt
kded/daemon.cpp
kded/daemon.h
kded/osd.cpp
kded/osd.h
kded/osdmanager.cpp
kded/osdmanager.h
kded/qml/Osd.qml
kded/qml/OsdItem.qml
kded/qml/OutputIdentifier.qml
tests/CMakeLists.txt
tests/osd/CMakeLists.txt
tests/osd/main.cpp
tests/osd/osdtest.cpp
tests/osd/osdtest.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sebas, #plasma
Cc: plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161205/b1f92d86/attachment.html>
More information about the Plasma-devel
mailing list