[Differential] [Request, 14 lines] D3594: [Notifications] Never manually hide() the NotificationPopup

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Otherwise the positioner will get completely confused.
  When a notification is closed, the popup will already be closed in response to sourceRemoved. Also, when triggering an action, call closePopup instead of hiding the popup.

TEST PLAN
  I created a persistent notification and clicked an action button in the popup. The popup closed but the slot was still reserved so any new notification would show up in 2nd slot. I could also reproduce this with some Electron (Chrome runtime) web apps that seem to use the notification API in creative ways, ie. the bug would trigger but the notification wasn't persistent.
  
  With this patch I can no longer reproduce the issue.
  
  One part in me wants to backport to 5.8.5 but the other part finds the notification code very complex and fragile.
  
  Another issue I spotted, unrealted to this, is the actions disappear when triggering them on the popup but stay in the history if notification is persistent. Needs a further/proper fix as there's apparently now a hint for persistent notifications to also keep their action buttons persistent.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3594

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/Notifications.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161205/6cb7317d/attachment.html>