[Differential] [Request, 87 lines] D3590: [libinput] Sane unset behaviour of scroll method and acceleration profile properties
subdiff (Roman Gilg)
noreply at phabricator.kde.org
Mon Dec 5 02:55:31 UTC 2016
subdiff created this revision.
subdiff added a reviewer: KWin.
subdiff added a subscriber: plasma-devel.
subdiff set the repository for this revision to R108 KWin.
subdiff added a project: KWin.
Restricted Application added a subscriber: kwin.
REVISION SUMMARY
Unsetting a scroll method should only work, if the scroll method is currently active. For example when scroll-two-finger is active (i.e. scroll-edge, scroll-on-button-down is not active):
- unsetting scroll-two-finger should deactivate it and activate no-scroll
- but unsetting for example scroll-edge should **not** deactivate scroll-two-finger and **not** activate no-scroll
Reworked setting scroll method auto test in order to test it.
Regarding acceleration profiles: Unsetting one, should always switch to the other possible one as long as both are supported. In this case LIBINPUT_CONFIG_ACCEL_PROFILE_NONE is not a valid option in contrast to the definition of the scroll method enums.
TEST PLAN
Manually and auto tests.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D3590
AFFECTED FILES
autotests/libinput/device_test.cpp
libinput/device.cpp
libinput/device.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #kwin
Cc: kwin, plasma-devel, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161205/4c1add88/attachment.html>
More information about the Plasma-devel
mailing list