[Differential] [Updated] D3578: [RFC] Implement drag from free space also for QtQuickControls

[hpereiradacosta (Hugo Pereira Da Costa)]

hpereiradacosta added a comment.


  in principle, no objection to the patch, but (big but): breeze style is supposed to compiled and be used against both qt4/kde4 and kf5, this as long as we still have kde4 applications around
  
  There is an option (-DUSE_KDE4=true) in the CMakeLists to test that. (and quite some #if BREEZE_USE_KDE4 in the code)
  
  This patch completely breaks kde4 compilation: there is no QQuickItem in Qt4, nor QWindow (so that all changes QWidget -> QWindow are not allowed)
  
  in the end, I think you better of forking BreezeWindowManager for QQuickItems, an use it only if not under kde4, possibly moving the widget move technology (wayland and stuff) to a common baseclass.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3578

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, hpereiradacosta
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161204/816e517d/attachment.html>