[Differential] [Request, 7 lines] D3559: [Notification Popup] Clear notification data after popup closed

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Thu Dec 1 14:41:14 UTC 2016


broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  There's no point in keeping around the notification data until it is replaced by a new one.

TEST PLAN
  Verified that e.g. the thumbnail strip is destroyed when the popup closes. Also keeps it from doing stupid things (like requesting new thumbnails while closing) etc.
  
  Might also reduce teh likeliehood of layout glitches when we always start with a "fresh" notification content rather than some old actions and what not hanging around. Layouts are quite fragile...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3559

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/plugin/notificationshelper.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161201/bbdbb467/attachment.html>


More information about the Plasma-devel mailing list