[Differential] [Request, 15 lines] D3557: [Notifications] Default initialize notificationProperties as empty object

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Thu Dec 1 10:46:16 UTC 2016


broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Avoids accessing the object twice for every property and improves readability.

TEST PLAN
  Notification title, text, icon still work. Configure button also shows up properly and so do the thumbnails. No (additional) warnings printed on console

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3557

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationPopup.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161201/fb9f6e02/attachment.html>


More information about the Plasma-devel mailing list