Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

[Eike Hein]

> On July 28, 2016, 6:02 a.m., Painless Roaster wrote:
> > Ship It!
> 
> Eike Hein wrote:
>     Do you need someone to commit this for you?
> 
> Painless Roaster wrote:
>     I do not have an account on github.
> 
> Eike Hein wrote:
>     Thanks, I'll see about getting this in next week.

Can you give me a real name I can use on the commit?


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128423/#review97884
-----------------------------------------------------------


On July 13, 2016, 1:13 p.m., Painless Roaster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128423/
> -----------------------------------------------------------
> 
> (Updated July 13, 2016, 1:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=361097
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> fix rename file (or folder) in folder plugin (and desktop in folder mode)
>  - enable multiline edit
>  - fix size and position
>  - fix escape from edit if user pressed Esc
>  - fix suppress open file (or folder) if user clicked in editbox
>  - fix size and position in popup mode
> 
> 
> Diffs
> -----
> 
>   containments/desktop/package/contents/ui/FolderView.qml ced3507 
> 
> Diff: https://git.reviewboard.kde.org/r/128423/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Painless Roaster
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160830/bfbef8f5/attachment-0001.html>