Review Request 128802: task bar lines

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128802/#review98786
-----------------------------------------------------------



Nice work!

Combining the best of both worlds, unintrusive lines where possible but filled background where needed.

I like that the text somewhat "sits" on the line (top panel) but descenders of letters like "g" and "q" overlap it. Not sure if that is a big deal, though.

The line of the active window (focus) should use ButtonFocus though as that's what the lines for expanded applets use. In Honeycomb currently the active window has a yellow line whereas expanded applets like Kickoff get a dark gray line. (In Breeze they're both blue)

- Kai Uwe Broulik


On Aug. 29, 2016, 10:21 nachm., Andreas Kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128802/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2016, 10:21 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Update of the tasks.svgz file
> 
> focus task
> ----------
> had now a 3px height line in Highlight color (direction of the line is the same than the lines in kicker, system tray, ...
> 
> normal task
> -----------
> no line no color at all no indicator. breeze mean no additional unusefull information and space for the elements to breath
> 
> hover task
> ----------
> blue Highlight color line like focus task with additional Highlight color background and 24% opacity
> 
> attention task
> --------------
> had a 3px height line in NeutralText color (old one didn't use colorscheme here)
> 
> minimzed task
> -------------
> rectangular element with Text color and 0.16% opacity (you can see it now in breeze and breeze-dark color scheme)
> 
> I know it's to late for kf5.26 (03.09) but however if you think it should be available with plasma 5.8 LTS let me know.
> 
> 
> Diffs
> -----
> 
>   src/desktoptheme/breeze/widgets/tasks.svgz 15a5921 
> 
> Diff: https://git.reviewboard.kde.org/r/128802/diff/
> 
> 
> Testing
> -------
> 
> the stylesheed stuff were checked with different color schemes and with kate in the svg "source code".
> 
> 
> File Attachments
> ----------------
> 
> the tasks.svgz file for your tests please copy it to your plasma theme dictionary
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/fe0f0fc4-2952-4711-8965-bfdca0eeaee1__tasks.svgz
> preview of the different tasks (inkscape file preview)
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/223b09e7-44a5-4431-bb7c-ad64a78a39e3__preview.png
> Breeze Preview
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/8c0dc0f2-88b5-4da8-84c5-d9acbb04c10e__Breeze.png
> Breeze Dark Color Scheme
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/6ab1fb1b-47bc-4a1b-a9ba-991d4371070c__Breeze-Dark.png
> Arch Color Scheme
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/c09eddcb-7026-400d-8246-3ed4f24a6e45__Arch.png
> Oxygen Color Scheme
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/4cfe2879-9234-4625-abcc-188942628e81__Oxygen.png
> Honeycomb color scheme
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/5ed41231-fddd-4b30-9087-f1e702ade7ac__Honeycomb.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160830/403cbaba/attachment-0001.html>