Review Request 128760: Fix crash on exit

[Peter Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128760/
-----------------------------------------------------------

(Updated Aug. 27, 2016, 11:04 a.m.)


Review request for Plasma, David Edmundson, David Faure, and Hugo Pereira Da Costa.


Changes
-------

Remove delete hack completely


Summary (updated)
-----------------

Fix crash on exit


Bugs: 356940
    https://bugs.kde.org/show_bug.cgi?id=356940


Repository: breeze


Description (updated)
-------

Since Qt 5.6.0, Qt5 applications started crashing on exit. All signs
point to this delete-on-destroy hack which was added to avoid outliving
the plugin lifetime.

This method is wrong because the returned style is owned by the caller
(QApplication, QProxyStyle, etc) and will cleaned up when those users
are destructed.


Diffs (updated)
-----

  kstyle/breezestyleplugin.cpp 083100e 

Diff: https://git.reviewboard.kde.org/r/128760/diff/


Testing (updated)
-------

Ran the updated test.sh from "Testcase (ASAN) with normal QApplication::quit and exit()" from bug https://bugs.kde.org/show_bug.cgi?id=356940, no longer crashes. Tested with Qt 5.7.0.


Thanks,

Peter Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160827/1cb1843f/attachment.html>