[Differential] [Request, 8 lines] D2596: [Colors KCM] Disable "Edit Scheme" button if cannot be edited
broulik (Kai Uwe Broulik)
noreply at phabricator.kde.org
Fri Aug 26 20:15:14 UTC 2016
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The default scheme cannot be edited, yields a "Scheme not found" error when trying to, and when no scheme is selected, we cannot edit it either.
TEST PLAN
When edit scheme dialog closes, no scheme is selected in the list, previously the KCM would crash when clicking Edit scheme again. I also no longer get a "Scheme not found" warning when trying to edit the default scheme because I no longer can.
It's quite annoying that the buttons have no edit or remove icon, though.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2596
AFFECTED FILES
kcms/colors/colorscm.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160826/c1986978/attachment.html>
More information about the Plasma-devel
mailing list