Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

[David Edmundson]

> On Aug. 26, 2016, 11:16 a.m., Martin Gräßlin wrote:
> > Ship It!

Not merging yet as someone (loa) on IRC reports a crash with this - I'm quite sure I know what it'll be, the runnable trying to access WindowThumbnail after it's been deleted. I think I'll have to split all the vars that I marked should only be used from the render thread into a separate struct.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128763/#review98684
-----------------------------------------------------------


On Aug. 26, 2016, 1:04 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128763/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2016, 1:04 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> WindowThumbnail did some open GL operations, discarding old textures, in the GUI thread. Whislt it's not going to cause a threading issue (as updatePaintNode always ran when the main thread was blocked) we're not meant to mix threads with openGL contexts.
> 
> It also seems to have a GL leak on nvidia, which was previously masked
> by the double delete fixed in https://git.reviewboard.kde.org/r/126131/diff/2/
> It seems only one worked, and in the applied version we went with the wrong one.
> 
> This patch makes use of QQuickItem::releaseResources to delete the GL
> textures on window change and destructor; it's then removed from
> stopRedirecting so that start/stop redirecting handles xcb on the GUI thread and updatePaintNode/discardPixmap is the GL stuff on the render thread. 
> 
> See http://doc.qt.io/qt-5/qquickitem.html#graphics-resource-handling
> 
> REVIEW:
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/windowthumbnail.h 7276f95de16e71006618f3282d8eaf419a199d1d 
>   src/declarativeimports/core/windowthumbnail.cpp d106994315099ab6e6f948c31a606d5309ae03e2 
> 
> Diff: https://git.reviewboard.kde.org/r/128763/diff/
> 
> 
> Testing
> -------
> 
> Using nvidia with proprietory drivers (which puts me QSG_RENDER_LOOP=threaded) mouse over the panel a lot. VRAM didn't increase. Previews still appear. 
> "Used Dedicated Memory:" in nvidia-settings remained roughly static, rather than constantly increasing.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160826/b588cd8a/attachment.html>