Review Request 128761: Fix crash when using QProxyStyle and exit()

[Peter Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128761/
-----------------------------------------------------------

(Updated Aug. 26, 2016, 12:07 a.m.)


Review request for Plasma, David Edmundson, David Faure, and Hugo Pereira Da Costa.


Bugs: 356940
    https://bugs.kde.org/show_bug.cgi?id=356940


Repository: oxygen


Description (updated)
-------

Do not delete all style instances which we create, restrict ourselves to
the first instance. I have no idea if the delete hack is still needed,
but let's keep it until it is certain that it is unneeded.

Copied from breeze patch https://git.reviewboard.kde.org/r/128760/


Diffs
-----

  kstyle/oxygenstyleplugin.cpp 70b90d9 

Diff: https://git.reviewboard.kde.org/r/128761/diff/


Testing
-------

Started `QT_STYLE_OVERRIDE=oxygen LD_LIBRARY_PATH=... QT_PLUGIN_PATH=... wireshark -o` (an invalid option that triggers `exit(1)`) and observe a heap-use-after free similar to the one reported in the bug. Apply this patch, rebuild oxygen and notice that the crash is fixed.


Thanks,

Peter Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160825/42bba091/attachment.html>