Review Request 128760: Fix crash when using QProxyStyle and exit()

Peter Wu peter at lekensteyn.nl
Thu Aug 25 21:56:44 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128760/
-----------------------------------------------------------

Review request for Plasma, David Edmundson, David Faure, and Hugo Pereira Da Costa.


Bugs: 356940
    https://bugs.kde.org/show_bug.cgi?id=356940


Repository: breeze


Description
-------

Do not delete all style instances which we create, restrict ourselves to
the first instance. I have no idea if the delete hack is still needed,
but let's keep it until it is certain that it is unneeded.


Diffs
-----

  kstyle/breezestyleplugin.cpp 083100e 

Diff: https://git.reviewboard.kde.org/r/128760/diff/


Testing
-------

Used "Testcase (with ASAN)" from bug https://bugs.kde.org/show_bug.cgi?id=356940. Run directly, no more crashes. Double-checked with a breakpoint on Breeze::StylePlugin::create that the second instance is called through QProxyStyle.


Thanks,

Peter Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160825/e21b17b9/attachment.html>


More information about the Plasma-devel mailing list