Review Request 128753: [PlasmaComponents TextField] Don't bother loading icons for not used buttons

Kai Uwe Broulik kde at privat.broulik.de
Thu Aug 25 21:00:22 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128753/
-----------------------------------------------------------

(Updated Aug. 25, 2016, 9 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 3f17e32a9289a3eb2984aa09c29b632d3d929efc by Kai Uwe Broulik to branch master.


Repository: plasma-framework


Description
-------

We kept loading the clear button and reveal password icons even when that option was disabled and the buttons not visible.


Diffs
-----

  src/declarativeimports/plasmacomponents/qml/TextField.qml d51fc5b 

Diff: https://git.reviewboard.kde.org/r/128753/diff/


Testing
-------

Still works.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160825/2526762d/attachment.html>


More information about the Plasma-devel mailing list