Review Request 128753: [PlasmaComponents TextField] Don't bother loading icons for not used buttons

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128753/#review98627
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On Aug. 25, 2016, 9:29 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128753/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2016, 9:29 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> We kept loading the clear button and reveal password icons even when that option was disabled and the buttons not visible.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/TextField.qml d51fc5b 
> 
> Diff: https://git.reviewboard.kde.org/r/128753/diff/
> 
> 
> Testing
> -------
> 
> Still works.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160825/f5ae91f8/attachment.html>