[Differential] [Commented On] D2550: add a preview button and a fullscreen preview

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcm.h:55
> this seems like a different change

ah, right, i dropped the part about HasDefaultLayoutRole, will remove

> davidedmundson wrote in main.qml:145
> Why the Plasma one? Everything else is QQC in this file?

as explained in the message, is purely an estetic thing, there the plasma one is fine as is on top of the thumbnail, that is an area where the qstyle control wouldn't visually work at all.
It's coherent with the ksplash kcm (i'm fine with an alternate design that works, but both should be updated)

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2550

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160823/1fa56ad7/attachment.html>