[Differential] [Accepted] D2542: Simplify code

[mart (Marco Martin)]

mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kirigamiplugin.h:85
>      {
> -        #ifdef Q_OS_WIN
> -        // On Windows, the leading slash does not make sense, so let's snip that off
> -        return baseUrl().path().mid(1) + QLatin1Char('/') + path;
> -        #else
> -        return baseUrl().path() + QLatin1Char('/') + path;
> -        #endif
> +        return baseUrl().toLocalFile() + QLatin1Char('/') + path;
>      }

even tough tolocalfile should always behave correctly, did you actually try this on windows? a bit uneasy to remove platform specific code without testing it on that platform

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2542

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160823/c236ded2/attachment.html>