[Differential] [Request, 12 lines] D2538: [FolderView] Base decision on effectiveLayoutDirection instead of layoutDirection

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, safaalfulaij, hein.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The code in many places already tried to take care of right-to-left layout but it was operating on layoutDirection which never actually changes if the layout is mirrored. "effectiveLayoutDirection" tells you what the actual direction is.

TEST PLAN
  Enabled LayoutMirroring on the desktop containment and:
  
  - Rubber band selection now selects the correct files (rather than their mirrored counterparts)
  - Dragging and dropping files drops them at the right place (rather than the opposite corner)
  - Keyboard nav left actually moves selection left instead of right

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2538

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, safaalfulaij, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160822/05d4a4e3/attachment.html>