[Differential] [Request, 69 lines] D2530: Move implementation of iconGeometry from ShellClient to AbstractClient
graesslin (Martin Gräßlin)
noreply at phabricator.kde.org
Mon Aug 22 15:00:25 UTC 2016
graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY
This allows Client to use the Wayland-specific implementation if there
is no icon geometry set through the X11 way. That way Xwayland windows
have an icon geometry even if Plasma is using Wayland and setting the
icon geometry in the Wayland way. Which is expected as Plasma is
ignorant about the windowing system a PlasmaWindow uses.
In order to move the code from ShellClient to AbstractClient
WaylandServer gained a new findAbstractClient(Surface*) method which
is just like findClient(Surface*) with the difference that it returns
an AbstractClient instead of a ShellClient*.
TEST PLAN
minimized/unminimized an X client on Wayland, verified
animation is correct (though broken in general for minimize)
REPOSITORY
rKWIN KWin
BRANCH
icongeometry-abstract-client
REVISION DETAIL
https://phabricator.kde.org/D2530
AFFECTED FILES
abstract_client.cpp
abstract_client.h
client.cpp
shell_client.cpp
shell_client.h
wayland_server.cpp
wayland_server.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160822/35379ed2/attachment.html>
More information about the Plasma-devel
mailing list