[Differential] [Commented On] D2515: Remove unused property

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Sun Aug 21 11:42:51 UTC 2016


broulik added a comment.


  Don't you need plasma core for units? I thought we didn't want to pull that in for startup time of the splash.

INLINE COMMENTS

> Splash.qml:46
> +            property int gridUnit: boundingRect.height
> +            property int largeSpacing: units.largeSpacing
> +            property int smallSpacing: Math.max(2, gridUnit/4)

This doesn't make sense, you bind the thing to itself.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2515

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160821/acae8fac/attachment.html>


More information about the Plasma-devel mailing list