Review Request 128721: monochrome kicker icons

[Andreas Kainz]

> On Aug. 20, 2016, 8:14 nachm., Marco Martin wrote:
> > personally, i like it.
> > 
> > as for the new name for the leave section, is this intended for plsma 5.8 as well?
> 
> Andreas Kainz wrote:
>     which new name for the leave section? I didn't change anything of the naming only icon stuff
> 
> Marco Martin wrote:
>     that's what i understood you did?
>     "add a new icon name for the leave section in kicker (new name -> problem with other themes from kaos, manjaro, ...)"

ah sorry no I would prefere to have solution 1 with monochrome icons only, but if the plasma team didn't like the monochrome icons for solution 2 a new icon name for leave is needed (for plasma 5.8).


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128721/#review98514
-----------------------------------------------------------


On Aug. 20, 2016, 12:49 nachm., Andreas Kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128721/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2016, 12:49 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> the kicker icons are the only colored icon in the plasma breeze theme all other icons are monochrome.
> 
> As the system icons are now again only monochrome the leave icon in kicker would be monochrome so there are two posibilities:
> 
> 1. make the other kicker icons also monochrome (see this request)
> 2. add a new icon name for the leave section in kicker (new name -> problem with other themes from kaos, manjaro, ...)
> 
> 
> Diffs
> -----
> 
>   src/desktoptheme/breeze/icons/applications.svgz 190f195 
>   src/desktoptheme/breeze/icons/bookmarks.svgz 6b52e8a 
>   src/desktoptheme/breeze/icons/computer.svgz fcbe605 
>   src/desktoptheme/breeze/icons/view.svgz fc0272f 
> 
> Diff: https://git.reviewboard.kde.org/r/128721/diff/
> 
> 
> Testing
> -------
> 
> with breeze and breeze dark theme
> 
> monochrome icons:
> https://dl.dropboxusercontent.com/u/1642456/vdg/Cantor/kickerMonochrome.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160820/efb7c571/attachment-0001.html>