[Differential] [Commented On] D2502: New design for logout screen

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> broulik wrote in Logout.qml:45
> Can we have an enum for that?

it is an enum coming somewhere from solid, i don't think it has bindings?

> broulik wrote in Logout.qml:128
> Given you already set currentAction based on the sdtype, could be simplified to
> 
>   opacity: root.currentAction === action ? 1 : 0.6
> 
> This would also ease the keyboard nav stuff.

doesn't seem to work, apparently comparing a signal and a var that contains the same signal is false :/

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2502

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160819/fce17dd8/attachment.html>